On 03/08/2018 09:30 PM, Simon Glass wrote:
Hi Heinrich,
input.c uses PS/2 scan codes at present. However these are somewhat internal. You should see docs in input.h
I am not sure of the best approach, but one would be to convert USB scan codes to PS/2 codes.
Regards, Simon
Hello Simon, hello Marek,
thanks for the clarification.
Between input.c and usb_kbd.c we have the following differences:
- Most keycodes are different. - The way ALT, CTRL, SHIFT, META are transferred differ. - Input.c has implemented support for different keyboard layouts (EN, DE) which is not easily expandable to other layouts.
So if we wanted to have a common layer this would require a complete rewrite of both input.c and usb_kbd.c.
I do not have access to any device using input.c. So I am unable to test any of it.
So I would prefer if we could just patch usb_kbd.c to provide the missing special keys and keep the code separate.
Having usb_kbd.c in directory common/ looks like a misplacement. It could be put under drivers/input/ or under drivers/usb/hid/. I think in future we should have also mouse and touchscreen as hid drivers. Otherwise using an EFI menu on a tablet will not be possible. So I would prefer moving usb_kbd to drivers/usb/hid/.
Best regards
Heinrich