Hi Wolfgang, Thanks for reviewing this patch. Please find my response in-lined
On Tuesday 06 March 2012 08:09 PM, Wolfgang Denk wrote:
Dear Prabhakar Kushwaha,
In message1329296027-28471-1-git-send-email-prabhakar@freescale.com you wrote:
This describes requirement of e500 and e500v2 processor to support any debugger. it also provide an insight of switch used and defined.
Signed-off-by: Radu Lazarescuradu.lazarescu@freescale.com Signed-off-by: Prabhakar Kushwahaprabhakar@freescale.com
Applies on http://git.denx.de/u-boot.git branch master
doc/README.mpc85xx_debugger | 44 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 doc/README.mpc85xx_debugger
This document contains a number of typos and othe rerrors, mixed with inconsitent indentation (some lines use TABs, others use spaces).
I suggest you clean it up and have it reviewed by a native speaker before resubmitting.
I will take care of your review-comments and will have first review at native level before floating it again.
Regarding the split into 4 separate patches: this makes no sense to me. For example, in this patch you reference new (and undocumented config options like CONFIG_E500_V1_V2) without ever using them.
Please squash patches.
My objective was to have separate patch for every logical piece. That's why I sent a series of patch. I will request you to let them as series for better understanding of others.
May be in each patch before use of any #define (related to debugger), I will write a comment. Please suggest.
Regarding CONFIG_E500_V1_V2, Its description is also part of this patch or is it not cleared ?
--Prabhakar