
Hi Upakul,
Thanks for the replies. I am attaching herewith, the patch which I suppose should fix the issue in NetLoop().
Thanks, but nowadays we would appreciate if you could send a patch with a proper commit message and a Signed-Off-By line. Just look at recent patches here on the mailing list to see what I mean. Oh and by the way, version 1.2.0 will not get any update fixes so please base your patch on the top of tree of git, thanks.
--- u-boot-1.2.0_orig/net/net.c 2007-01-07 04:43:11.000000000 +0530 +++ u-boot-1.2.0/net/net.c 2007-11-14 18:03:03.000000000 +0530 @@ -305,7 +305,7 @@ #ifdef CONFIG_NET_MULTI eth_set_current(); #endif
- if (eth_init(bd) < 0) {
- if (eth_init(bd) > 0) { eth_halt(); return(-1); }
Secondly and more important, did you test this? I'd say your test is the wrong way round, i.e. eth_init returns true in the C sense (!=0) if it was able to initialize an interface. (This also chimes with the naming of the function by the way). So I'd propose to go for "!eth_init(..)".
Cheers Detlev