Re: [PATCH v14 1/2] net: Add TCP protocol

Hi Ying, You woke up an old can, Can you elaborate on the changes you did to the original patchset ? I'm reviewing this instead of Joe, so I want to get some context.

I would appreciate it if you could separate the SACK support to a separate patch, preferably option based. The TCP stack is complicated enough and will require a lot of tinkering / bug fixing in the future. It's best if we could turn on/off specific RFC which are not originally part of the TCP protocol.

Thanks, Ramon

Hi Ramon,

Please review this patch again.

I've added an option to disable/enable SACK. However it is harder to separate the SACK support as a separate commit. I continue the old one which was together with SACK already.

Thanks a lot, Paul