In message 45c77d7eac24c@wp.pl you wrote:
This patch adds support for Pruftechnik's ROTALIGN Alpha board.
The patch allows to upload and flash Linux, then boots it.
The second flash bank and SMC9196 chip do not work yet.
* Please clean up the Coding style violations (C++ comments, trailing white space, indentation not by TAB, ...).
* Please remove dead code like here:
--- u-boot-1.1.6/board/raalpha/config.mk 1970-01-01 01:00:00.000000000 +0100 +++ u-boot-1.1.6.ra/board/raalpha/config.mk 2006-11-02 15:15:01.000000000 +0100 @@ -0,0 +1,3 @@ +#TEXT_BASE = 0xa1700000 +TEXT_BASE = 0xa3080000 +#TEXT_BASE = 0
* Please explain why you think this is necessary:
+int board_late_init(void) +{ + setenv("stdout", "serial"); + setenv("stderr", "serial"); + return 0; +}
Then resubmit.
Best regards,
Wolfgang Denk