Re: [PATCH 4/6] drivers: tpm: atmel_twi: do not use an offset byte

On Thu, 4 Nov 2021 at 03:14, Mathew McBride matt@traverse.com.au wrote:

This driver was broken due to an empty offset byte being prepended at the start of every transmission.

The hardware does not mimic an EEPROM device with registers so an offset byte is not required.

Signed-off-by: Mathew McBride matt@traverse.com.au

drivers/tpm/tpm_atmel_twi.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/tpm/tpm_atmel_twi.c b/drivers/tpm/tpm_atmel_twi.c index 4ff4cf4cd4..71b101406d 100644 --- a/drivers/tpm/tpm_atmel_twi.c +++ b/drivers/tpm/tpm_atmel_twi.c @@ -131,6 +131,7 @@ static int tpm_atmel_twi_xfer(struct udevice *dev,

static int tpm_atmel_twi_probe(struct udevice *dev) {

•   i2c_set_chip_offset_len(dev, 0);
    return 0;
  

}

-- 2.30.1

Acked-by: Ilias Apalodimas ilias.apalodimas@linaro.org