Hi Wolfgang,
Wolfgang Denk wrote:
Dear Ben,
In message 1256115432-31992-1-git-send-email-wd@denx.de I wrote:
So far, TFTP negotiated a fixed retransmission timeout of 5 seconds. In some cases (busy networks, slow TFTP servers) this caused very slow transfers. Add new environment variable "tftptimeout" allows to set this timeout. Lowering this value may make downloads succeed faster in networks with high packet loss rates or with unreliable TFTP servers.
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Ben Warren biggerbadderben@gmail.com
I'm not sure if this change is really a good thing. It seems to help a lot in a test case I had here, but I'm not sure if the previous timeout settings that also depended on TftpRRQTimeoutMSecs were simply wrong (and not well tested - in myunderstanding they should affect only the connection timeout, but not the packet retransmission timeout), or if these are actually useful or needed in some configurations. So far, TftpRRQTimeoutMSecs is used in common/update.c only.
README | 19 ++++++++++++++++--- net/tftp.c | 22 +++++++++++++++++----- 2 files changed, 33 insertions(+), 8 deletions(-)
Any comment son that patch? Should I submit it for inclusion?
See http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/70097
Best regards,
Wolfgang Denk
I have a bunch of things in my 'for next' inbox that need to be processed (as your e-mails indicate). I plan on going through them tonight.
regards, Ben