25 Jan
2021
25 Jan
'21
9:08 p.m.
Hi Dario,
On Sun, 24 Jan 2021 at 11:13, Dario Binacchi dariobin@libero.it wrote:
It is useless and misleading to print the ret variable that is not set by the dev_read_addr routine. Also, move the '\n' character after the round bracket that contains the error code.
Signed-off-by: Dario Binacchi dariobin@libero.it
drivers/ata/ahci_sunxi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
You could consider using log_debug() (with LOG_CATEGORY defined at the top) and then you can drop the __func__ stuff.
Regards, Simon