Simon,
On Tue, Sep 18, 2012 at 12:37 PM, Simon Glass sjg@chromium.org wrote:
Hi Tom,
On Wed, Sep 12, 2012 at 3:10 PM, Tom Warren twarren.nvidia@gmail.com wrote:
Signed-off-by: Tom Warren twarren@nvidia.com
arch/arm/cpu/arm720t/tegra30/Makefile | 48 +++ arch/arm/cpu/arm720t/tegra30/board.h | 25 ++ arch/arm/cpu/arm720t/tegra30/config.mk | 26 ++ arch/arm/cpu/arm720t/tegra30/cpu.c | 570 ++++++++++++++++++++++++++++++++ arch/arm/cpu/arm720t/tegra30/cpu.h | 65 ++++ arch/arm/cpu/arm720t/tegra30/spl.c | 132 ++++++++
It certainly has complicated your work, with the AVP arm720t refactor going in before these patches.
In some ways, yes. In others, it made it easy to first get a SPL (AVP) U-Boot up and printing its sign-on, and then having a base to work from/debug A9 code for the second, CPU-init half.
I feel that quite a bit of the code here should perhaps go to arch/arm/cpu/arm720t/tegra-common or similar, so that you can share it with tegra30.
WIP. There'll be an arch/arm/cpu/arm720t/tegra-common, an arch/arm/cpu/armv7/tegra-common, and even an arch/arm/cpu/tegra-common, plus an arch/arm/include/asm/arch-tegra to hold common code & include files.
How those changes will be captured in a patchset (or 2) that show the movement of the original Tegra20 files, then the copy/edit for Tegra30 is still to be seen.
Thanks,
Tom
Regards, Simon