Re: [U-Boot] [PATCH v3 1/2] pwm: sunxi: add support for PWM found on Allwinner A64

Hi,

On Sat, Apr 28, 2018 at 02:05:14PM -0700, Vasily Khoruzhick wrote:

+static const struct udevice_id sunxi_pwm_ids[] = {

• { .compatible = "allwinner,sun50i-a64-pwm" },
• { }

+};

+U_BOOT_DRIVER(sunxi_pwm) = {

• .name = "sunxi_pwm",
• .id = UCLASS_PWM,
• .of_match = sunxi_pwm_ids,
• .ops = &sunxi_pwm_ops,
• .ofdata_to_platdata = sunxi_pwm_ofdata_to_platdata,
• .probe = sunxi_pwm_probe,
• .priv_auto_alloc_size = sizeof(struct sunxi_pwm_priv),

+};

The binding should be the same one than used in Linux. Once that is fixed, for both patches, Acked-by: Maxime Ripard maxime.ripard@bootlin.com

Thanks! Maxime