
22 Sep
2015
22 Sep
'15
5:52 a.m.
Hi Marek,
On 09/22/2015 08:10 AM, Marek Vasut wrote:
I suspect you might want to tweak the core code to check if those .set_speed and .set_mode are assigned in dm_spi_ops structure and if not, don't call them.
I wonder if this worths, as altera_spi is the only one that cannot set speed and mode.
- plat->regs = ioremap(dev_get_addr(bus),
sizeof(struct altera_spi_regs));
I guess the same thing about ioremap() and ranges applies here?
Same thing about ioremap(), as almost every other arch does not include it in u-boot. You see that I just added it to nios2 lately.
Sometimes the address returned by dev_get_addr() may be used as memory, and does not need ioremap.
Best regards, Thomas