Wolfgang,
On 07/04/2011 05:28 AM, Wolfgang Denk wrote:
Dear Rob Herring,
In message 1309275583-11763-1-git-send-email-robherring2@gmail.com you wrote:
From: Rob Herring rob.herring@calxeda.com
This series enables non-PCI AHCI controllers and adds support for Calxeda Highbank platform which uses the AHCI changes.
Changes from v3:
- Added Highbank to MAINTAINERS
- Added back patch to fix CONFIG_SKIP_LOWLEVEL_INIT (mistakenly dropped
from v2)
Wolfgang, Albert,
Can you apply these to your trees for v2011.09? All review comments have been addressed.
I have to admit that I dislike the way you are working.
If I'm not wrong, there have been several versions of your patches around, but you repost again and again without any indication that these are reposts, nor what exactly has been changed between versions. For example, I see three different posts here:
06/11 Rob Herring [U-Boot] [PATCH 8/8] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101435 06/21 Rob Herring [U-Boot] [PATCH 1/5] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101867 06/28 Rob Herring [U-Boot] [PATCH 2/6] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102124
None of these adheres to the requirements as documented here: http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
Please be aware that NOT documentaing what you changed means that all (potential) reviewers of your code have to spend additional time figuring out what you might have changed, and checking back in the history if you really implemented all earlier review comments. Speaking for me, I must state that being notoriously short of time I am not willing to waste additional time on such postings, so I tend to ignore them.
In short: please stick to the rules if you want your patches to go into mainline.
Sorry about this. I will follow this more closely going forward. Much of the significant change was to the series itself and less so the content itself. I added Highbank support based on you wanting to see a platform use the AHCI changes. Then I dropped the SDHCI changes as another "common" implementation appeared on the list and it will take some time to sort out.
The history for "ARM: Add Calxeda Highbank platform" is: v2: - Move SATA and MMC board init to separate patches - Fix DRAM size setup v3: - Add maintainer
I can repost it if you like with the history, but I'd like to get any review comments from you first.
Up until my last post, the following patches have had no comments and no changes. They were only reposted as part of the whole series:
ARM: add missing CONFIG_SKIP_LOWLEVEL_INIT for armv7 arm: add __ilog2 function scsi/ahci: ata id little endian fix
I have posted v2 of "arm: add __ilog2 function" and v3 of "scsi/ahci: add support for non-PCI controllers" as a replies to the prior versions.
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102679 http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102775
Regards, Rob