Re: [U-Boot-Users] [PATCH0/2] Re-do the patch for adding DO_SYNC in flash_write_cmd

In message 200702100840.46587.sr@denx.de you wrote:

...

...

Or, to be sure, ""sync;isync"

I would not do this. Please let a "sync" instruction _not_ do a "isync" too. There will be times when you explicitly _don't_ what this.

Note that the current assember #define SYNC does exactly what I quoted above...

Why not use

#define sync() __asm__ __volatile__ ("sync" : : : "memory");

from include/asm-ppc/io.h? This seems to be exactly what we need.

Indeed. Let's use that!

Best regards,

Wolfgang Denk