Hi,
On Wed, May 16, 2012 at 2:31 PM, Stephen Warren swarren@wwwdotorg.orgwrote:
On 05/16/2012 03:27 PM, Tom Warren wrote:
Stephen, Stephen Warren wrote at Wednesday, May 16, 2012 9:21 AM:
This implements a useful bootcmd for Tegra. The boot order is:
...
I'm getting checkpatch errors (over 80 chars) for tegra2-common-post.h:
WARNING: line over 80 characters #414: FILE: include/configs/tegra2-common-post.h:93:
"script_boot="\...
True.
In this case, I would assert these should simply be ignored; checkpatch is a tool to help you get readable source, and in this case I think it's much more readable by not forcing artificial wrapping.
Acked-by: Simon Glass sjg@chromium.org
Although I would prefer that things stick to 80cols. In this particular code it doesn't seem hard to fix this. Everything who comes along later to change this code will hit it.
Regards, Simon