Hi,
On Tue, 28 Feb 2023 at 10:25, Tom Rini trini@konsulko.com wrote:
On Tue, Feb 28, 2023 at 03:56:05PM +0000, Peter Robinson wrote:
The use of OF_EMBED isn't recommended for standard use and the OF_BOARD is actually a better fit for the Raspberry Pi as the prior firmware provides a DT that can be used by U-Boot and the subsequent OS too, but it still allows the loading of a DT from disk as well if users wish to use the upstream kernel DT.
Signed-off-by: Peter Robinson pbrobinson@gmail.com
configs/rpi_0_w_defconfig | 2 +- configs/rpi_2_defconfig | 2 +- configs/rpi_3_32b_defconfig | 2 +- configs/rpi_3_b_plus_defconfig | 2 +- configs/rpi_3_defconfig | 2 +- configs/rpi_4_32b_defconfig | 1 + configs/rpi_4_defconfig | 1 + configs/rpi_arm64_defconfig | 1 + configs/rpi_defconfig | 2 +- 9 files changed, 9 insertions(+), 6 deletions(-)
My only concern is from when I did: https://patchwork.ozlabs.org/project/uboot/patch/20211224165704.2855211-1-tr... so I think you need to also drop the "imply OF_HAS_PRIOR_STAGE" from the Kconfig files and should probably move to select (do not allow the user to override this, it shall always be OF_EMBED now), or at least imply (sufficiently advanced users may want a different choice and should be able to make it).
This very old patch seems to have arrived in my queue. I am pleased to see it!
From my understanding the correct thing here is to 'imply
OF_HAS_PRIOR_STAGE' in the Kconfig, which is done for some rpi boards but not all. Then the OF_BOARD setting becomes the default.
We should not really 'select OF_HAS_PRIOR_STAGE' since it makes testing with a U-Boot-supplied DT impossible.
Regards, Simon