Re: [U-Boot] [PATCH 01/40] binman: Don't generate an error in 'text' entry constructor

On Wed, Jan 30, 2019 at 12:00 PM Simon Glass sjg@chromium.org wrote:

It is not good practice to raise an exception in a constructor. In this case the 'text' entry may not actually be used, if -i is used to filter out the images that get built.

Move the exception to where the data is actually used.

Signed-off-by: Simon Glass sjg@chromium.org

tools/binman/etype/text.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Bin Meng bmeng.cn@gmail.com