Re: [U-Boot] [PATCH 4/4] rapidio: add driver for TI KeyStone RapidIO

On Tue, Nov 10, 2015 at 01:13:53PM +0100, jacquiot.aurelien@gmail.com wrote:

From: Aurelien Jacquiot a-jacquiot@ti.com

This commit includes the KeyStone device driver for RapidIO allowing to use the RapidIO boot functionality.

Today only K2HK devices have RapidIO support.

Signed-off-by: Aurelien Jacquiot a-jacquiot@ti.com

[snip]

+#define debug_rio(fmt, args...) if (rio_dbg) printf(fmt, ##args)

Please use the normal debug() macro here.

[snip]

• if (count >= KEYSTONE_RIO_TIMEOUT_CNT) {
  

• 	debug_rio(
  

• 		"RIO: timeout %d, ltid = %d, context = %d, lcb = %d, cc = %d\n",
  

• 		count, ltid, context, lcb, status);
  

Here and elsewhere we have a bit of a funny line-break. It's OK to do: debug("String that exceeds 80 char wide\n", align, all, variables, on, other, lines);