Re: [PATCH V2] rockchip: rk3328: add rockpie-rk3328_defconfig

On Thu, Apr 9, 2020 at 7:12 PM b.l.huang banglang.huang@foxmail.com wrote:

From f4253df37579aa9d48f98738eb7db3b6a3b9dff5 Mon Sep 17 00:00:00 2001 From: "banglang.huang" banglang.huang@foxmail.com Date: Thu, 9 Apr 2020 11:49:31 +0800 Subject: [PATCH V2] rockchip: rk3328: add rockpie-rk3328_defconfig

The ROCKPI-E is a credit card size SBC based on Rockchip RK3328 Quad-Core ARM Cortex A53.

Net - Dual ethernet port, 1 X Gbe, 1 X 100M
USB - USB 3.0
DC  - USB-Type C, 5V 2A
Storage - TF card, eMMC

Just build u-boot-dtb.bin for Rockpi E board and follow the blow steps to replace the relevant partition.

./rkbin/tools/loaderimage --pack --uboot u-boot-dtb.bin \ uboot.img 0x200000 --size 1024 1 dd if=uboot.img of=/dev/sdcard seek=16384 conv=notrunc

Signed-off-by: banglang.huang banglang.huang@foxmail.com

Changes for v2

- add introduction for rockpie in doc/README.rockchip
- enable CONFIG_MISC_INIT_R, CONFIG_SMBIOS_MANUFACTURER,
  and CONFIG_SMBIOS_PRODUCT_NAME

arch/arm/dts/Makefile | 3 +- arch/arm/dts/rk3328-rockpie-u-boot.dtsi | 12 ++ arch/arm/dts/rk3328-rockpie.dts | 256 ++++++++++++++++++++++++ board/rockchip/evb_rk3328/MAINTAINERS | 7 + configs/rockpie-rk3328_defconfig | 99 +++++++++

Can you separate the different bits of the board name? For instance we already have

rock-pi-4-rk3399_defconfig / rk3399-rock-pi-4.dts, so

rock-pi-e-rk3328_defconfig / rk3328-rock-pi-e.dts

should fit the bill.

Also, rockpie will not be pronounced the same way as rock-pi-e. Rockpie will simply become rock pi, which does wonders for figuring out which board one is referring to.

ChenYu