Wolfgang Denk wrote:
Dear Stefan Roese,
In message 200812090638.36452.sr@denx.de you wrote:
Regarding Ben's comments:
First, thanks for reviewing. You gave me two different approaches to consider, 1) using in/out functions, and 2) using a structure. So, for this version, I've followed the style of the example you gave, using the structure approach.
No, you _need_ to use the in_/out_() accessor functions. This is unrelated to using plain addresses and offsets vs. a structure. I really welcome the change to the structure in this version, so please just add the in_()/out_() functions upon accessing the SoC registers.
Hm... Seems this is a reply to an off-list message?
Steven, please make sure to keep the ML on Cc: !
Best regards,
Wolfgang Denk
Looks on-list to me:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/51194
regards, Ben