Re: [U-Boot] [PATCH v3 29/30] net: rtl8169: Use non-cached memory if available

On Wed, Nov 12, 2014 at 06:27:15PM -0700, Simon Glass wrote: [...]

diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index fc8c31e..cd26c36 100644 --- a/drivers/net/rtl8169.c +++ b/drivers/net/rtl8169.c @@ -41,6 +41,7 @@

• Modified to use le32_to_cpu and cpu_to_le32 properly

*/ #include <common.h> +#include <errno.h> #include <malloc.h> #include <net.h> #include <netdev.h> @@ -290,16 +291,15 @@ struct RxDesc {

• cases the driver will likely fail because the CPU needs to flush the cache
• when requeuing RX buffers, therefore descriptors written by the hardware
• may be discarded.

• • This can be fixed by defining CONFIG_SYS_NONCACHED_MEMORY which will cause
• • the driver allocate descriptors from a pool of non-cached memory.

Self-correct: s/driver allocate/driver to allocate/

Thierry