Hi Heinrich,
On Thu, Dec 28, 2023 at 5:11 PM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Am 27. Dezember 2023 08:40:40 MEZ schrieb Simon Glass sjg@chromium.org:
Hi Heinrich,
On Tue, Dec 26, 2023 at 10:11 AM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 12/26/23 10:47, Simon Glass wrote:
Hi Heinrich,
On Sat, Dec 23, 2023 at 12:49 AM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Provide a unit test for the smbios command.
Provide different test functions for QEMU, sandbox, and other systems.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
test/py/tests/test_smbios.py | 47 ++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 test/py/tests/test_smbios.py
Can you please write this test in C?
Regards, Simon
According to our documentation we can use either Python or C tests. We generally use Python tests for testing the CLI.
Not really...there are lots of C tests for the CLI. It is actually easier to code, in most cases.
I cannot see any benefit in trying to write this in C.
I did go to some effort to document this:
https://docs.u-boot.org/en/latest/develop/tests_writing.html#test-types
As described in that document C is most adequate for testing on the sandbox. I want to run this test on QEMU and real boards with release U-Boot firmware, i.e. without deviating configuration.
Are you checking that the compiler works? Most such tests are a waste of time, IMO. Anyway, any test is better than no test, as Tom says, so:
Reviewed-by: Simon Glass sjg@chromium.org
Regards, SImon