Re: [U-Boot] [PATCH 10/16] drivers/video/cfb_console.c: Add support for some ANSI terminal escape codes

On Saturday 17 December 2011 12:03:12 Pali Rohár wrote:

• This patch add support for cursor move and reverse colors via ANSI

espace codes in cfb_console driver * ANSI escape codes can be enabled/disabled via CONFIG_CFB_CONSOLE_ANSI

your changelog needs to be line wrapped

• 	case 7:
  

• 		if ((ansi_buf[i] >= 'A' && ansi_buf[i] <= 'H') || 
  

ansi_buf[i] == 'J'

|| ansi_buf[i] == 'K' || ansi_buf[i] == 'm') { + cchar

= ansi_buf[i];

this line is way too long -mike