Re: [U-Boot] [PATCH V2 09/13] ARM: tegra: use clrsetbits_le32 in pinmux driver

Dear Stephen Warren,

In message 5331A6B6.8090805@wwwdotorg.org you wrote:

...

Or perhaps update_reg_mask_shift_val()?

Still, I can rename the function if you want; it certainly does make it obvious. It's rather a long name though, but I guess wrapping the parameters isn't too bad.

Please do not invent new bit manipulation functions. Just use the standard I/O accessors. And whenever possible, please remove pre- existing functions.

I've just recently sent patches to get rid of such "inventions" that resulted in undefined code.

Best regards,

Wolfgang Denk