On Friday 12 February 2010 10:16:36 Teh Kok How wrote:
- What exactly are you trying to fix? Please add a small description on what's broken and how your patch fixes it.
=> Fixes wrong argument to mtd_id_parse that affects u-boot command `erase` and `protect` <part-id>. This fix passes the correct part-id to the commands so that `erase rootfs` and `protect rootfs` work.
- Patch adds empty line after each line
- Patch is line wrapped
=> Hope it's better this time as I am sure I use "Plain Text" in my email body.
- Signed-off-by line missing
Signed-off-by: Kok How, Teh k_h_teh@yahoo.com --- u-boot-2009.11.1.orig/common/cmd_flash.c 2010-01-25 16:35:12.000000000 +0800 +++ u-boot-2009.11.1.new/common/cmd_flash.c 2010-02-12 16:18:10.565540182 +0800 @@ -43,6 +43,7 @@
Thanks. But your patch is still line wrapped. Please take a look a this page on how to send patches:
http://kerneltrap.org/Linux/Email_Clients_and_Patches
And please remove my comments from the commit text. It should look like this:
" Fixes wrong argument to mtd_id_parse that affects u-boot command `erase` and `protect` <part-id>. This fix passes the correct part-id to the commands so that `erase rootfs` and `protect rootfs` work. "
And please add a small description to the email subject. Something like:
cmd_flash: Fix mtdparts usage in "erase" and "protect"
Thanks.
Cheers, Stefan
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de