Dear Kim,
in message 20080520185809.df32b5cc.kim.phillips@freescale.com you wrote:
minor nit in comparison, but:
Applying Big white-space cleanup. .dotest/patch:20954: trailing whitespace.
cpu/ixp/npe/IxEthAccMii.c
.dotest/patch:20984: trailing whitespace.
cpu/ixp/npe/IxNpeDlNpeMgrUtils.c
.dotest/patch:21019: trailing whitespace. ixQMgrAqmIfQueAccRegAddr[i] =
cpu/ixp/npe/IxQMgrAqmIf.c
.dotest/patch:21152: trailing whitespace. BOOL speed100, .dotest/patch:21153: trailing whitespace. BOOL fullDuplex,
Both cpu/ixp/npe/include/IxEthMii.h
it looks like it's in u-boot-testing that way, too - maybe you can amend it? other than that things look clean(er):
I'm not sure about this. This are all files in the "cpu/ixp/npe/" which are full of white space issues. Some time ago there was a decision not clean those up to keep the code as close to the original as possible. All these trailing white space is already present in the original versions of the files, i.e. the patch doesn't make it worse. Maybe I shouldn't have touched these files at all, but I forgot to tell my script about them.
The whole code in the "cpu/ixp/npe/" is going to be replaced soon by the new driver code that has gone into mainline Linux recently. Thak makes me think we should not spend too much effort on this. Basicly I see three options:
1) Be lazy and leave as is now 2) Go forward and clean up all white space issues in the /npe/ code 3) Revert the white-space cleanup patches as far as /npe/ code is affected.
Short discussion on IRC showed preference for 1).
If you agree, that's what we'll do.
Best regards,
Wolfgang Denk