Re: [U-Boot-Users] [PATCH 0/1] TFTP: add host ip addr support

Jean-Christophe PLAGNIOL-VILLARD wrote:

@@ -464,19 +464,27 @@ TftpStart (void) printf ("*** Warning: no boot file name; using '%s'\n", tftp_filename); } else {

• tftp_filename = BootFile;
  

• char *p=BootFile;
  

• p = strchr (p, ':');
  

• if (p != NULL) {
  

• 	TftpServerIP = string_to_ip (BootFile);
  

• 	++p;
  

• 	strcpy (tftp_filename, p);
  

• } else {
  

• 	strcpy (tftp_filename, BootFile);
  

• }
  

Doesn't this mean that TftpServerIP will be undefined if no server is specified. Should it not be:

@@ -464,19 +464,27 @@ TftpStart (void) printf ("*** Warning: no boot file name; using '%s'\n", tftp_filename); } else { - tftp_filename = BootFile; + char *p=BootFile; + p = strchr (p, ':'); + if (p != NULL) { + TftpServerIP = string_to_ip (BootFile); + ++p; + strcpy (tftp_filename, p); + } else { + TftpServerIP = NetServerIP; + strcpy (tftp_filename, BootFile); + }

Andre