Re: [U-Boot] [PATCH 02/14] sunxi: Add support for the rsb (Reduced Serial Bus)

18 Dec 2014


      On Wed, 2014-12-17 at 13:56 +0100, Hans de Goede wrote:
...
...
...
@@ -128,7 +128,8 @@
  #define SUN6I_CPUCFG_BASE              0x01f01c00
  #define SUNXI_R_UART_BASE              0x01f02800
  #define SUNXI_R_PIO_BASE               0x01f02c00
-#define SUNXI_P2WI_BASE                        0x01f03400
+#define SUNXI_P2WI_BASE                        0x01f03400      /* on sun6i */
+#define SUNXI_RSB_BASE                 0x01f03400      /* on sun8i */
Maybe we just use SUN6I_ SUN8I_ prefixes?
The base address will be different on sun9i.
Did you miss this suggestions from Chen-Yu? Seems like a good one.
I don't have any other comments.
Ian.

    

Ian Campbell