Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

Dear Simon Glass,

In message CAPnjgZ1bMkN3xoNCqtg1CLMa=0rgpHsuyHyZg5yOkR3Hk+v+Bw@mail.gmail.com you wrote:

nit: circular. Just a suggestion if you like: you could also offer guidance for the location of the buffer, something like:

You can place the buffer at the top of memory by adding something like this in your board config file:

#define CONFIG_PRE_CON_BUF_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \ CONFIG_SYS_INIT_RAM_SIZE - \ CONFIG_PRE_CON_BUF_SZ) #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_PRE_CON_BUF_ADDR - \ GENERATED_GBL_DATA_SIZE)

That would only make sense if these were generic options that are used across all boards and architectures.

Best regards,

Wolfgang Denk