Hello,
On Wed, Nov 29, 2023 at 07:45:28PM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 27 Nov 2023 at 11:16, Tom Rini trini@konsulko.com wrote:
On Mon, Nov 27, 2023 at 06:56:44PM +0600, Maxim Uvarov wrote:
add external lwIP library as a git submodule. Use STABLE-2_2_0_RELEASE tag.
Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org
And just for the record, we'll re-visit submodule/subtree/whatever later on, this (and the final parts for CI to be happy about it) are a means to an end.
While I understand this, I would still like to see a patch containing the actual code. We are at v11 here.
This is why submodules are evil.
You *can* produce a patch that contains the code but you have to *remember* to pass the argument.
And if the patch does contains the code it is likely not applicable because then it does not contain the revision to which the submodule should be updated.
Submoudules may be a generally good idea but they are not well implemented in git.
Thanks
Michal