Hi Asherah,
On Fri, Mar 5, 2021 at 10:31 PM Simon Glass sjg@chromium.org wrote:
Hi Asherah,
On Thu, 4 Mar 2021 at 21:16, Asherah Connor ashe@kivikakk.ee wrote:
Hi Simon,
On 21/03/04 11:03:p, Simon Glass wrote:
This looks sensible but it really is a huge patch. Can it be split up a bit?
This is a rejig of v4 previously Reviewed-by: you, see https://patchwork.ozlabs.org/project/uboot/list/?series=230778&state=%2a.
If I previously reviewed it you can add my tag.
Bin Meng suggested the patch be reworked along these lines so that MMIO and Arm support were added separately, see https://patchwork.ozlabs.org/project/uboot/patch/20210224032323.15798-2-ashe....
Thanks for making the split.
I'm happy to rework it further but it's not clear to me what the best way to do that is. Perhaps separating out the qfw.h Sphinx documentation and sandbox driver/tests? Let me know, I would like to get it right.
I think sandbox driver/tests being separate is a good idea.
Yes, as Simon said, sandbox driver/test should be a separate patch.
Regards, Bin