Re: [U-Boot] [PATCH 2/2] cmd_itest.c: fix pointer dereferencing

Hi Frans,

fix pointer dereferencing if the size is .b and .w an 8 or 16 bit access is done.

Signed-off-by: Frans Meulenbroeks fransmeulenbroeks@gmail.com

You could have included my previously given Acked-by. But anyway:

Acked-by: Detlev Zundel dzu@denx.de

---

common/cmd_itest.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/common/cmd_itest.c b/common/cmd_itest.c index 5b301bf..58c5e7b 100644 --- a/common/cmd_itest.c +++ b/common/cmd_itest.c @@ -66,12 +66,17 @@ op_tbl_t op_table [] = {

static long evalexp(char *s, int w) {

• long l, *p;

• long l = 0;

• long *p;

  /* if the parameter starts with a * then assume is a pointer to the value we want */ if (s[0] == '*') { p = (long *)simple_strtoul(&s[1], NULL, 16);

• l = *p;
  

• switch (w) {
  

• case 1: return((long)(*(unsigned char *)p));
  

• case 2: return((long)(*(unsigned short *)p));
  

• case 4: return(*p);
  

• }
  

  } else { l = simple_strtoul(s, NULL, 16); }