Hi Mario,
On 14 July 2017 at 05:54, Mario Six mario.six@gdsys.cc wrote:
From: Dirk Eibach dirk.eibach@gdsys.cc
m88e1510_config() is highly board-specific. So add an optional callback board_m88e1510_config() configurable by CONFIG_BOARD_M88E1510_CONFIG to support different hardware.
Signed-off-by: Dirk Eibach dirk.eibach@gdsys.cc Signed-off-by: Mario Six mario.six@gdsys.cc
drivers/net/phy/marvell.c | 5 +++++ include/marvell-phy.h | 10 ++++++++++ 2 files changed, 15 insertions(+) create mode 100644 include/marvell-phy.h
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 66107a8af3..b3d05d5af4 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -9,6 +9,7 @@ #include <config.h> #include <common.h> #include <errno.h> +#include <marvell-phy.h> #include <phy.h>
#define PHY_AUTONEGOTIATE_TIMEOUT 5000 @@ -381,6 +382,9 @@ static int m88e1518_config(struct phy_device *phydev) /* Marvell 88E1510 */ static int m88e1510_config(struct phy_device *phydev) { +#ifdef CONFIG_BOARD_M88E1510_CONFIG
board_m88e1510_config(phydev);+#else
We should not be calling into board code from drivers. How could we do this with driver model / DT?
/* Select page 3 */ phy_write(phydev, MDIO_DEVAD_NONE, MIIM_88E1118_PHY_PAGE, MIIM_88E1118_PHY_LED_PAGE);@@ -401,6 +405,7 @@ static int m88e1510_config(struct phy_device *phydev)
/* Reset page selection */ phy_write(phydev, MDIO_DEVAD_NONE, MIIM_88E1118_PHY_PAGE, 0);+#endif
return m88e1518_config(phydev);} diff --git a/include/marvell-phy.h b/include/marvell-phy.h new file mode 100644 index 0000000000..1cfa5ed557 --- /dev/null +++ b/include/marvell-phy.h @@ -0,0 +1,10 @@ +#ifndef _MARVELL_PHY_H +#define _MARVELL_PHY_H
+#include <phy.h>
+void m88e1518_phy_writebits(struct phy_device *phydev,
u8 reg_num, u16 offset, u16 len, u16 data);+int board_m88e1510_config(struct phy_device *phydev);
+#endif
2.11.0
Regards, Simon