Hi Marek,
-----Original Message----- From: Biju Das Sent: 15 January 2021 10:02 To: Marek Vasut marek.vasut@gmail.com; Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Prabhakar Mahadev Lad prabhakar.mahadev-lad.rj@bp.renesas.com; u- boot@lists.denx.de; Chris Paterson Chris.Paterson2@renesas.com; Simon Glass sjg@chromium.org; Tom Rini trini@konsulko.com Subject: RE: [PATCH v7 1/4] arm: rmobile: Add RZ/G2[HMNE] SoC support
Hi,
Subject: RE: [PATCH v7 1/4] arm: rmobile: Add RZ/G2[HMNE] SoC support
diff --git a/arch/arm/mach-rmobile/cpu_info-rcar.c b/arch/arm/mach-rmobile/cpu_info-rcar.c index 5bde24ae0e..08345503a2 100644 --- a/arch/arm/mach-rmobile/cpu_info-rcar.c +++ b/arch/arm/mach-rmobile/cpu_info-rcar.c @@ -6,6 +6,7 @@ */ #include <common.h> #include <asm/io.h> +#include <soc.h>
#define PRR_MASK 0x7fff #define R8A7796_REV_1_0 0x5200 @@ -21,9 +22,28 @@ static u32 rmobile_get_prr(void) #endif }
+static bool is_rzg_family(void) +{
- bool rzg_family_type = false;
- struct udevice *soc;
- char name[16];
- if (!(soc_get(&soc) || soc_get_family(soc, name, 16))) {
This depends on some other patchset, right ? I will wait for that to land and then apply this one.
Yes, Simon have reviewed this patches and not sure who needs to pick this up. So I have sent a gentle remainder for picking this patches [1] [1] http://u-boot.10912.n7.nabble.com/PATCH-v4-0-4-Add-Renesas-SoC- identification-driver-support-tt432936.html
Did you check that this is still OK on RCar Gen2 with its size-limited SPL?
Good catch. I have built spl image for koelsch and I see there is a change in Size of SPL with and without soc identification driver + SoC uclass driver included
With SoC identification driver + SoC uclass driver included -----------------------------------------------------------
$ ls -al spl/u-boot-spl.bin -rwxr-xr-x 1 biju biju 13996 Jan 16 14:16 spl/u-boot-spl.bin $ size spl/u-boot-spl text data bss dec hex filename 13789 204 1100 15093 3af5 spl/u-boot-spl
Without SoC identification driver + SoC uclass driver ----------------------------------------------------- $ ls -al spl/u-boot-spl.bin -rwxr-xr-x 1 biju biju 13916 Jan 16 14:19 spl/u-boot-spl.bin size spl/u-boot-spl text data bss dec hex filename 13785 128 1100 15013 3aa5 spl/u-boot-spl
I will post V5 with Renesas soc identification driver disabled for SPL builds along with SoC uclass driver.
Regards, Biju