On 17 Jul 2017, at 12:51, Łukasz Majewski lukma@denx.de wrote:
Hi Marek,
On 07/17/2017 10:39 AM, Łukasz Majewski wrote:
On 07/14/2017 06:27 PM, Philipp Tomsich wrote:
Up to now, there's been some ugliness associated with the dependency from CMD_USB_MASS_STORAGE to USB_FUNCTION_MASS_STORAGE: if someone only defined CMD_USB_MASS_STORAGE, they'd meet a linker error due to missing symbols that came from USB_FUNCTION_MASS_STORAGE.
Most platforms seem to have resorted to unconditionally enable USB_FUNCTION_MASS_STORAGE via their 'common' config-header... some tried to tie this to an #ifdef CMD_USB_MASS_STORAGE (in fact I had a patch for the RK3399 that did just that and rather decided to clean this up once and for all instead of contributing to the prolongation of the status quo). Neither is a good solution.
So this series moves USB_FUNCTION_MASS_STORAGE to Kconfig and lets CMD_USB_MASS_STORAGE imply USB_FUNCTION_MASS_STORAGE. Finally, we run moveconfig to contain the damage.
Thanks for the patch.
Rewieved-by: Lukasz Majewski lukma@denx.de
I was trying to apply those patches to Marek's -usb tree, but with some issues.
Marek, would you be some kind and update your's u-boot-denx-usb tree?
It's on u-boot/master + 1 patch for a while ... what's your problem ?
That is the patch 3/3 which causes the problem :-)
No issues from my side :-D
(HEAD -> refs/heads/master, refs/remotes/deploy/master)
807598a60c | Masahiro Yamada | usb: add static to local symbols
e14b1169c0 | Tom Rini | Merge git://www.denx.de/git/u-boot-marvell
Also cutting the screwed up CC list *eyeroll*
Yeah, I've realized that this list is too long after I've repied.
Philipp, could you make patch 3/3 applicable to Marek's u-boot-usb/master tree?
Rebased onto u-boot-usb/master and resubmitted.
The CC list will still be excessive... but that’s due to moveconfig touching large amounts of files and patman trying to keep everyone informed.
Regards, Philipp.