I think it will be best, that I add this new NAND driver code into a branch of the u-boot-nand-flash custodian repository. But only after the first issues are solved. For example I found quite a lot of coding style issues in your patch:
- Leading white spaces
- Trailing white spaces
- Indentation seems to be sometimes with 4 spaces instead of using a tab
- C++ comments (//)
Please clean this up. I'll send a more detailed review soon.
I will clean up and then update the branches on the git server. I will also send patches to the mailing list containing all the small files. For the big files, I will point to the git server (with a reference to each changed file) as they are too big to fit under the current size limit. Is this OK? Or must I put a patch file as a pure text file on the web server?
Note that this is one big patch and splitting the patch per file when emailing it to the list will render each (sub-)patch broken. But as Jerry Van Baren recently suggested (in another thread), the patch can be pulled as a whole from the git server and using the list will preserve the review concept.
In my next thread I will also change the subject as Wolfgang suggested.
Best regards, William