Re: [U-Boot] [PATCH] I2C: mxc_i2c rework

Dear Marek Vasut,

In message 1310578117-7687-1-git-send-email-marek.vasut@gmail.com you wrote:

Rewrite the mxc_i2c driver.

• This version is much closer to Linux implementation.
• Fixes IPG_PERCLK being incorrectly used as clock source
• Fixes behaviour of the driver on iMX51
• Clean up coding style a bit ;-)

Signed-off-by: Marek Vasut marek.vasut@gmail.com

drivers/i2c/mxc_i2c.c | 414 +++++++++++++++++++++++++++++++++---------------- 1 files changed, 281 insertions(+), 133 deletions(-)

NAK.

You submitted a changed (?) version, but without marking this as such in the subject, and without providing a changelog. Please see http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

And don't forget to add the necessary reference to the Linux code you referred to.

Best regards,

Wolfgang Denk