On Fri, 2014-03-14 at 19:11 +0800, Chen-Yu Tsai wrote:
Thanks for working on this!
No problem.
I see you left out all the CONFIG_RGMII ifdefs from this file. Not sure if it's because you're aiming to support only the Cubietruck first.
Yes, exactly.
I think you should keep them in the same patch. You can then just add the appropriate config options when support of other A20 boards roll in.
I don't have any boards which require this, so I cannot test it. I'd prefer to leave it to whoever adds support for the first such board to put this stuff back in, it's a pretty trivial git diff invocation to spot the needed bits.
There are 3 changes to the designware driver since u-boot-sunxi's last merge (2014.1-rc1):
50b0df8 net/designware: make driver compatible with data cache 92a190a net/designware - switch driver to phylib usage 74cb708 net/designware: add explicit reset of {tx|rx}_currdescnumThe move to phylib will likely break the current code. Maybe we could merge 2014.4-rc1 in to fix it first.
I'm happy to track any merges updates etc, sounds like at least this patch will need some rebasing. Since this one is last I think it needn't stop the rest going in (although I anticipate at least some review and rebasing for all of it).
Also, GMAC support depends on
5a51af3 net/designware: Reduce DMA burst lengthby Jens Kuske (jemk). Neither of us bothered to send this upstream yet.
I think I saw that in the sunxi tree but since it touched core code I punted on it for now since I wasn't sure how to reconcile it with non-sunxi platforms (i.e. what is the downside for other boards? Worse performance?)
Thanks for your feedback.
Ian.