Re: [PATCH v3 03/10] lib: Makefile: build crc7.c when CONFIG_MMC_SPI

On Fri, Jan 24, 2020 at 11:21 AM Pragnesh Patel pragnesh.patel@sifive.com wrote:

When build U-boot SPL, meet an issue of undefined reference to 'crc7' for drivers/mmc/mmc_spi.c, so let's compile crc7.c when CONFIG_MMC_SPI selected.

Signed-off-by: Pragnesh Patel pragnesh.patel@sifive.com Reviewed-by: Anup Patel anup.patel@wdc.com

---

lib/Makefile | 1 + 1 file changed, 1 insertion(+)

diff --git a/lib/Makefile b/lib/Makefile index 51eba80b89..d21e0a6b3a 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -78,6 +78,7 @@ endif

ifdef CONFIG_SPL_BUILD obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o +obj-$(CONFIG_MMC_SPI) += crc7.o

It is invalid to mark crc7 to MMC_SPI, try to add Kconfig option for CRC7. like this. https://paste.ubuntu.com/p/kSnkDWpTgS/