
Hi Jason,
Two neats in addition to Fabio's comments below:
On 11/12/11 12:36, Jason Liu wrote:
Add the initial support for Freescale i.MX6Q Armadillo2 board Support: MMC boot from slot 0/1, debug UART(UART4), usdhc.
Signed-off-by: Jason Liu jason.hui@linaro.org
MAINTAINERS | 1 + board/freescale/mx6qarm2/Makefile | 48 ++++++++++ board/freescale/mx6qarm2/imximage.cfg | 167 +++++++++++++++++++++++++++++++++ board/freescale/mx6qarm2/mx6qarm2.c | 163 ++++++++++++++++++++++++++++++++ boards.cfg | 1 + include/configs/mx6qarm2.h | 163 ++++++++++++++++++++++++++++++++ 6 files changed, 543 insertions(+), 0 deletions(-)
[...]
diff --git a/board/freescale/mx6qarm2/Makefile b/board/freescale/mx6qarm2/Makefile new file mode 100644 index 0000000..5ca7ec1 --- /dev/null +++ b/board/freescale/mx6qarm2/Makefile @@ -0,0 +1,48 @@
[...]
+clean:
- rm -f $(SOBJS) $(OBJS)
+distclean: clean
- rm -f $(LIB) core *.bak .depend
Please, remove clean and distclean targets - they have no use and are being removed from board directory level Makefiles.
[...]
diff --git a/board/freescale/mx6qarm2/mx6qarm2.c b/board/freescale/mx6qarm2/mx6qarm2.c new file mode 100644 index 0000000..63322a9 --- /dev/null +++ b/board/freescale/mx6qarm2/mx6qarm2.c @@ -0,0 +1,163 @@
[...]
+int board_mmc_init(bd_t *bis) +{
- s32 status = 0;
- u32 index = 0;
- for (index = 0; index < CONFIG_SYS_FSL_USDHC_NUM; ++index) {
switch (index) {
case 0:
imx_iomux_v3_setup_multiple_pads(
usdhc3_pads, ARRAY_SIZE(usdhc3_pads));
break;
case 1:
imx_iomux_v3_setup_multiple_pads(
usdhc4_pads, ARRAY_SIZE(usdhc4_pads));
break;
default:
printf("Warning: you configured more USDHC controllers"
"(%d) then supported by the board (%d)\n",
index+1, CONFIG_SYS_FSL_USDHC_NUM);
Is it possible to put spaces around the '+' sign?
return status;
}
status |= fsl_esdhc_initialize(bis, &usdhc_cfg[index]);
- }
- return status;
+}
[...]