6 Aug
2009
6 Aug
'09
11:44 p.m.
Dear Kumar Gala,
In message CF3701B9-C6BD-4D04-BFEC-F5ABA43BF869@kernel.crashing.org you wrote:
+MPC8536DS_36BIT_config \ MPC8536DS_config: unconfig
- @$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8536ds freescale
- @mkdir -p $(obj)include
- @if [ "$(findstring _36BIT_,$@)" ] ; then \
echo "#define CONFIG_PHYS_64BIT" >>$(obj)include/config.h ; \$(XECHO) "... enabling 36-bit physical addressing." ; \- fi
- @$(MKCONFIG) -a MPC8536DS ppc mpc85xx mpc8536ds freescale
Argh... You know that I hate such long script-like parts in the top level Makefile. Please add such logic to the board config file instead.
Do you have an example of doing this for a single config option like this? I'm happy to fix things.
One possibility is to replace the ``findstring'' part with
@echo "#define CONFIG_$(@:_config=)" >$(obj)include/config.h
This way include/config.h will have either "#define CONFIG_MPC8536DS" or "#define CONFIG_MPC8536DS_36BIT", which can be trivially evaluated in your board config file.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Until you walk a mile in another man's moccasins, you can't imagine
the smell.