On 6/19/20 9:41 AM, Patrick DELAUNAY wrote:
Hi Marek,
From: Marek Vasut marex@denx.de Sent: jeudi 18 juin 2020 20:35
The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com
arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi index 75d75266e8..df63ad4a24 100644 --- a/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +++ b/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi @@ -273,6 +273,9 @@
&sdmmc1 { u-boot,dm-spl;
- broken-cd;
- /delete-property/ cd-gpios;
- /delete-property/ disable-wp;
};
&sdmmc1_b4_pins_a {
2.27.0
Reviewed-by: Patrick Delaunay patrick.delaunay@st.com
This fix should be included in v2020.07.... So I will prepare a pull request.
Just for information: I assumed that PULL_UP was correctly managed when I update the device tree.
Support is added in ucalss by the serie with the patches 788ea834124 ("gpio: add function _dm_gpio_set_dir_flags") 477ca57b9a5 ("gpio: add support of new GPIO direction flag")
But I forget that the driver part wasn't yet accepted / merged in master branch.
http://patchwork.ozlabs.org/project/uboot/list/?series=181294
In particular the commit "gpio: stm32: add ops set_dir_flags"
Today I target this serie in v2020.10 after review (I think it is late v2020.07 as it is impacting STM32MP MPU and STM32 MCU)
Sorry for disturbance....
No problem, thanks!