Hi Joe,
On Thu, May 28, 2015 at 12:13 AM, Joe Hershberger joe.hershberger@gmail.com wrote:
Hi Bin,
On Wed, May 27, 2015 at 11:01 AM, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Wed, May 27, 2015 at 11:55 PM, Bin Meng bmeng.cn@gmail.com wrote:
Commit bd328eb "Clean all defconfigs with savedefconfig" accidentally removed 'CONFIG_VENDOR_COREBOOT=y' from configs/coreboot-x86_defconfig. This commit reverts the change.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
configs/coreboot-x86_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig index 66f94d0..799853f 100644 --- a/configs/coreboot-x86_defconfig +++ b/configs/coreboot-x86_defconfig @@ -1,4 +1,5 @@ CONFIG_X86=y +CONFIG_VENDOR_COREBOOT=y CONFIG_TARGET_COREBOOT=y CONFIG_OF_CONTROL=y CONFIG_DM_PCI=y --
Please apply this patch after commit http://git.denx.de/?p=u-boot/u-boot-x86.git;a=commit;h=3506805839e14a67b0971... and before commit http://git.denx.de/?p=u-boot/u-boot-x86.git;a=commit;h=05cab1d6da2a84911fa0e.... I've verified the build with buildman on a new 'testing' branch with insertion of this patch.
This should be squashed as part of http://git.denx.de/?p=u-boot/u-boot-x86.git;a=commit;h=05cab1d6da2a84911fa0e...
You need to remember to run savedefconfig when changing Kconfig or defconfig.
I still don't get it. commit 65c4ac0 introduced 'CONFIG_VENDOR_COREBOOT=y' and was applied before your commit bd328eb to clean up the defconfig. I suspect there was something wrong with 'savedefconfig'?
Regards, Bin