Re: [U-Boot] [PATCH v3 2/6] usb: xhci: return ERR_PTR(-ETIMEDOUT) at the end of xhci_wait_for_event()

Hi Masahiro,

On Sun, Jan 28, 2018 at 6:18 PM, Masahiro Yamada yamada.masahiro@socionext.com wrote:

Bin, Marek,

Would you take a look at xHCI code?

Sorry I missed this before.

Lots of xHCI code invokes BUG_ON()/BUG() when the hardware access fails, then halts the system completely. This is not a software bug.

Given xHCI codes were originally from Linux where BUG_ON()/BUG() was once there but now disappears, I agree let's do it to clear the compiler warnings for now. Something needs to be done in the U-Boot xHCI codes to handle the error path properly.

Regards, Bin