ack on the 83xx change, but the 85xx code looks identical to the 83xx version, and 86xx bits should be identical, too, so we would be better off refraining from triplicating code again and find a more common place to put this. Jon? Andy?
Definitely true, but that's a delicate change. For instance, this UPM patch has the same logics for the 83xx & 85xx platforms, but the registers are different. Unifying this code should result in lots of ugly ifdefs.
btw, David, can you start including diffstats with your patch submissions? It makes it easier to see what's being touched at a glance, especially on the larger patches. You can simply use diffstat if you're not ready to use git-format-patch (which does this automatically for you).
Sure thing - will do.
David.