Hi Eugeniu, Masahiro,
So, it seems like all the trailing white-space from above files disappeared on your branch, after applying the patches from the email client (who did this?...).
I didn't expect that trailing white-space to be of any value for the test results, but it turns out it is! With the whitespace removed, I can also reproduce the failures of "make testconfig".
Right. Whitespaces are precious in the expected_stdout files. Do not rip them off.
I am not familiar with pytest, but, based on what we see here, it looks like every single character stored in *xpected_stdout files (including whitespace at the end of lines) matters for the test to pass.
I wonder if Kconfig could avoid printing whitespace in command line user dialogs. Then maybe those space characters could be removed from the "*xpected_stdout" files.
BTW this topic is more for linux-kbuild, than u-boot.
'make config' display a space at the end of line when prompting user input.
This makes the input readable, like follows:
- Linux/x86 4.17.0-rc4 Kernel Configuration
64-bit kernel (64BIT) [Y/n/?] y
- General setup
Cross-compiler tool prefix (CROSS_COMPILE) [] Compile also drivers which will not load (COMPILE_TEST) [N/y/?] y
I think you are suggesting to remove a space, like follows:
- Linux/x86 4.17.0-rc4 Kernel Configuration
64-bit kernel (64BIT) [Y/n/?]y
- General setup
Cross-compiler tool prefix (CROSS_COMPILE) [] Compile also drivers which will not load (COMPILE_TEST) [N/y/?]y
I believe we should not do this just for unit-testing.
Yes, that wouldn't make sense. I just have to be careful when applying patches :)
Masahiro?
Thanks again!
Best regards, Eugeniu.
Kind regards, Petr