Re: [PATCH 10/38] x86: Show an error when a BINS exception occurs

Am 30. März 2023 23:31:59 MESZ schrieb Simon Glass sjg@chromium.org:

Rather than silently hanging, show an error first. This can happen when there is something wrong with the video BIOS.

Signed-off-by: Simon Glass sjg@chromium.org

arch/x86/lib/bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/lib/bios.c b/arch/x86/lib/bios.c index 94349ba8073d..b28db31308f0 100644 --- a/arch/x86/lib/bios.c +++ b/arch/x86/lib/bios.c @@ -78,7 +78,8 @@ static int int_exception_handler(void) }; struct eregs *regs = &reg_info;

• debug("Oops, exception %d while executing option rom\n", regs->vector);

• log_err("Oops, exception %d while executing option rom\n",

Please, drop "Oops, " which does not add information. Do we have a function to convert the exception number to a string?

%s/rom/ROM/

Regards

Heinrich

• regs->vector);
  

  cpu_hlt();

  return 0;