Hi Tolunay,
On Tuesday 07 November 2006 19:01, Tolunay Orkun wrote:
Questions for the maintainers:
- I have some new variables for man_id, dev_id, cfi_version introduced by
this patch (actually man_id is currently not used so could be removed). I can kept these local to the function for now or I can add them to the info structure along with ext_addr (to easily locate the Vendor Extended Query Structure in flash). What do you think?
In the minimum displaying man_id, dev_id, cfi_version when executing "flinfo" command could be useful for diagnostic purposes. We might need to use them to tweak the behavior of some other functionality in the future as well.
Yes, I definitely think it's useful to display this ID information (or even better a real manufacturer/device string) in the "flinfo" command. So my vote is to extend the struct.
- There are some outdated comments at the beginning of the cfi_flash.c.
The modification history is not up to date and todo list stuff is mostly addressed over time. Since the actual history is already is the git, I propose to get rid of modification history and todo list from the comments.
ACK.
Thanks for helping out here.
Best regards, Stefan