Hi Michal,
There is a need to fill node before clk_output_sel is setup.
Could you be more specific about this issue ?
I assume that the issue is on a system where Xilinx is used. I did my work/testing on a system where TI's SoC was used instead, so I'm curious what are the problems on Xilinx.
Thanks in advance.
Signed-off-by: Michal Simek michal.simek@xilinx.com Acked-by: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
drivers/net/phy/ti.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c index 6db6edd0d0c8..10989dd40309 100644 --- a/drivers/net/phy/ti.c +++ b/drivers/net/phy/ti.c @@ -216,6 +216,10 @@ static int dp83867_of_init(struct phy_device *phydev) /* Optional configuration */
- node = phy_get_ofnode(phydev);
- if (!ofnode_valid(node))
return -EINVAL;- /*
- Keep the default value if ti,clk-output-sel is not set
- or to high
@@ -225,10 +229,6 @@ static int dp83867_of_init(struct phy_device *phydev) ofnode_read_u32_default(node, "ti,clk-output-sel", DP83867_CLK_O_SEL_REF_CLK);
- node = phy_get_ofnode(phydev);
- if (!ofnode_valid(node))
return -EINVAL;- if (ofnode_read_bool(node, "ti,max-output-impedance")) dp83867->io_impedance =
DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX; else if (ofnode_read_bool(node, "ti,min-output-impedance"))
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de