Hi Angus, On Tue, 2022-04-19 at 07:34 -0700, Angus Ainslie wrote:
Hi Alban, On 2022-04-19 01:07, Alban Bedel wrote:
The binding of iMX8MQ USB controller doesn't use child nodes like the other devices supported in this driver. To support it split the child nodes parsing to its own function and add a field to the platform data to indicate that we should just use the top node.
I'm not clear on what this is fixing. Doesn't the original code deal with a devicetree stanza that has the information in either the node or the parent.
I have now see your commit c08db05455bc ("usb: dwc3: dwc3-generic: check the parent nodes") which added the compatible for the imx8mq and reference the librem5 DTS. This DTS has `port` subnodes to define the connection to a type C connector. So with the compatible string you added the glue driver would interpret the port nodes as DWC3 nodes, hence the need to get properties from the parent node.
I think we should revert this patch and add support for standalone DWC3 devices instead. We could also improve the glue driver to only handle subnode with the proper compatible.
Alban