El Fri, Feb 12, 2010 at 08:01:26AM +0100 Alessandro Rubini ha dit:
i gave my ack after a visual review of the patch, without having tested it. i just installed a patched u-boot on one of my boards and it doesn't boot :(
Oh. The opposite of my board.
Then, since I don't have a 9315A but only a similar one, it's better to drop the patch. I'll have a different sdram_cfg file for mine, then.
i'm pretty sure we'll be able to track this down, the purpose of your patch is correct, i actually wonder why the current code works ...
if we can't solve the issue in the next days, you could still send a patch which only writes the GlConfig register in program_mode_registers(). this would fix at least on of the issues and make your code less different from the one in the tree